chore: clean up unnecessary webdriverio/spectron references #5342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR removes some unnecessary code and an unnecessary dependency on
webdriverio
that became obsolete when we switched the unified e2e tests from spectron to playwright. Per the comment in dependabot.yml, we were only usingwebdriverio
for typings shared between it andspectron
; it isn't required anymore.I also removed a few other lingering bits of dead code related to Spectron while I was here (eg, a bunch of timeout constants that we stopped using with the move to playwright).
Motivation
Originally, this was part of a PR to resolve a CG alert against the
async
package. The non-dev dependencies onasync
were resolved by other PRs and the specific CG alert in question isn't applicable to dev dependencies, so it's no longer necessary to do any further resolutions forasync
; however, I kept this bit of the PR since removing the unnecessary code still seemed nice.Context
n/a
Pull request checklist
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.